Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Sending funds to oracle account can cause consensus failure #292

Closed
yun-yeo opened this issue Nov 24, 2019 · 0 comments · Fixed by #293
Closed

[BUG] Sending funds to oracle account can cause consensus failure #292

yun-yeo opened this issue Nov 24, 2019 · 0 comments · Fixed by #293
Labels
bug Something isn't working

Comments

@yun-yeo
Copy link
Contributor

yun-yeo commented Nov 24, 2019 •
edited
Loading

Describe the bug
Sending funds to oracle account through bank/MagSend can cause consensus failure

If we send funds to oracle account before the account created by supply module through RewardBallotWinners func, the bank module will create general account with the module account address.

To Reproduce
Send funds to terra1jgp27m8fykex4e4jtt0l7ze8q528ux2lh4zh0f (oracle module account address) before oracle account created.

Context & versions
core v0.3.0-rc3

(if applicable) suggested solution
Call supplyKeeper.GetModuleAddressAndPermissions(oracle.ModuleName) at init genesis step in oracle module
@yun-yeo yun-yeo added the bug Something isn't working label Nov 24, 2019
@yun-yeo yun-yeo mentioned this issue Nov 24, 2019
Merged
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Bugfix] Create oracle account at init genesis terra-money/classic-core
1 participant
@yun-yeo