enable_xff_client_port No Longer Defaults to True in AWS Provider

[stewartcampbell]

Description

enable_xff_client_port now defaults to false in the provider.

I see chat here #284 about that not being the case previously.

Now they have reverted to the correct setting, the module should reflect that. I appreciate it means another default change, but in my opinion, it is being changed to the correct setting since that is the API default.

• ✋ I have searched the open/closed issues and my issue is not listed.

Versions

• Module version [Required]:
  v8.7.0
• Terraform version:
  n/a
• Provider version(s):
  v5.18.1

Reproduction Code [Required]

n/a

Steps to reproduce the behavior:

Use the module without configuring enable_xff_client_port.

Expected behavior

should default to false

Actual behavior

defaults to true

Terminal Output Screenshot(s)

n/a

Additional context

n/a

[Jarodiv]

Thanks for pointing that out, I've created PR #310 for the change.

[bryantbiggs]

this is resolved in #305

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.