feat: Implementation of the cpu_options block and addition of support for AMD SEV-SNP #334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
reviewed
May 17, 2023
bryantbiggs
requested changes
May 17, 2023
bryantbiggs
reviewed
May 24, 2023
main.tf
Outdated
| @@ -177,11 +187,9 @@ resource "aws_instance" "this" { | |||
| resource "aws_instance" "ignore_ami" { | |||
| count = local.create && var.ignore_ami_changes && !var.create_spot_instance ? 1 : 0 | |||
|
|
|||
| ami = try(coalesce(var.ami, nonsensitive(data.aws_ssm_parameter.this[0].value)), null) | |||
| instance_type = var.instance_type | |||
| cpu_core_count = var.cpu_core_count | |||
There was a problem hiding this comment.
these need to be re-added back
bryantbiggs
reviewed
May 24, 2023
main.tf
Outdated
| @@ -341,11 +359,9 @@ resource "aws_instance" "ignore_ami" { | |||
| resource "aws_spot_instance_request" "this" { | |||
| count = local.create && var.create_spot_instance ? 1 : 0 | |||
|
|
|||
| ami = try(coalesce(var.ami, nonsensitive(data.aws_ssm_parameter.this[0].value)), null) | |||
| instance_type = var.instance_type | |||
| cpu_core_count = var.cpu_core_count | |||
bryantbiggs
approved these changes
May 30, 2023
antonbabenko
pushed a commit
that referenced
this pull request
May 30, 2023
## [5.1.0](v5.0.0...v5.1.0) (2023-05-30) ### Features * Implementation of the cpu_options block and addition of support for AMD SEV-SNP ([#334](#334)) ([6a123ad](6a123ad))
|
This PR is included in version 5.1.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I have implemented the fix for the deprecation warning of cpu_core_count and cpu_threads_per_core attributes. Those can now be specified using the cpu_options block.
In addition, this PR adds the support for AMD SEV-SNP which is also a new attribute that can be set via the cpu_options block.
Motivation and Context
Breaking Changes
Yes, customers can no longer use the cpu_core_count and cpu_threads_per_core variables anymore.
Those have been removed in favor of a new variable cpu_options that can be used as below:
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request