Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use splat syntax to avoid errors during destroy with an empty state #1041

Merged

Conversation

barryib
Copy link
Member

@barryib barryib commented Oct 6, 2020

PR o'clock

Description

Resolves #568

Supersedes:

Checklist

@barryib
Copy link
Member Author

barryib commented Oct 6, 2020

@Carles-Figuerola @ageekymonk Can you please test this and let me know if it solves your issue.

local.tf Outdated Show resolved Hide resolved
@Carles-Figuerola
Copy link

@barryib thanks for consolidating, added a suggestion on a missed line

Co-authored-by: Carles-Figuerola <carles@figuerola.info>
@barryib
Copy link
Member Author

barryib commented Oct 6, 2020

@barryib thanks for consolidating, added a suggestion on a missed line

Thanks.

@barryib barryib changed the title fix: Use splat syntax to avoid error during destroy with an empty state fix: Use splat syntax to avoid errors during destroy with an empty state Oct 6, 2020
@barryib barryib merged commit d97edde into terraform-aws-modules:master Oct 12, 2020
@barryib barryib deleted the tba/splat-syntax-cluster-name branch October 12, 2020 19:59
barryib added a commit to Polyconseil/terraform-aws-eks that referenced this pull request Oct 25, 2020
@nick4fake
Copy link

@Carles-Figuerola thanks a lot for the merge!

Could you please create a new release?

@Carles-Figuerola
Copy link

@nick4fake, sorry, I'm not the one who merged or have write permissions, this is probably on @barryib's terrytory

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Terraform destroy fails when state is empty
3 participants