Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update autoscaler installation in IRSA example #1063

Merged
merged 5 commits into from
Nov 2, 2020
Merged

docs: Update autoscaler installation in IRSA example #1063

merged 5 commits into from
Nov 2, 2020

Conversation

aryklein
Copy link
Contributor

@aryklein aryklein commented Oct 22, 2020

PR o'clock

Description

This PR fixes two issues in the irsa example:

  1. Wrong chart values (or not compatible with the latest version). Please check this line: https://github.com/helm/charts/blob/a5632b118a97e829d9b93312ddc5816c3025d00b/stable/cluster-autoscaler/templates/serviceaccount.yaml#L8
  2. Updates the helm install command used as the Helm chart has been moved to the kubernetes/autoscaler repository.

Checklist

This change fixes the annotations issue in the kubernetes autoscaler chart
The Helm chart used in the example has been moved to the kubernetes/autoscaler repository
examples/irsa/README.md Outdated Show resolved Hide resolved
@barryib barryib changed the title docs: update irsa example docs: Update autoscaler installation in IRSA example Nov 2, 2020
@barryib barryib dismissed max-rocket-internet’s stale review November 2, 2020 21:10

Review has been fixed.

@barryib barryib merged commit e8a060f into terraform-aws-modules:master Nov 2, 2020
@barryib
Copy link
Member

barryib commented Nov 2, 2020

Thanks @aryklein for your contribution.

@aryklein
Copy link
Contributor Author

aryklein commented Nov 2, 2020

Thanks @aryklein for your contribution.

My pleasure!

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants