Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix IRSA example when deploying cluster-autoscaler from the latest kubernetes/autoscaler helm repo #1090

Conversation

brannondorsey
Copy link
Contributor

@brannondorsey brannondorsey commented Nov 6, 2020

PR o'clock

Description

Fixes #1083, which appears to have been introduced when the cluster-autoscaler helm chart was recently updated to point to the latest helm repo, instead of the deprecated one (#1063). The latest version of the chart deploys a service account named cluster-autoscaler-aws-cluster-autoscaler-chart instead of cluster-autoscaler-aws-cluster-autoscaler, which causes authentication errors unless updated.

I've also updated the instructions in the IRSA example README to reflect this change and link to the latest helm repo.

Checklist

…lm chart

* Update local.tf to use the correct service account name generated
  by the latest helm chart by default
* Update IRSA README Verify section to use correct name label values
* Update docs to use the latest helm chart repo instead of the
  deprecated one
Copy link
Member

@barryib barryib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thanks @brannondorsey for this update.

@barryib barryib merged commit 3cb8fa3 into terraform-aws-modules:master Nov 7, 2020
@barryib barryib added this to the v13.2.0 milestone Nov 7, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] IRSA example login errors
2 participants