fix: Don’t add empty Roles ARN in aws-auth configmap, specifically when no Fargate profiles are specified #1096
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
The new fargate code seems to have caused a bug in authmap.
Currently even when no fargate profiles are specified the fargate module output is used to create an authmap entry with an empty ARN.
The plan shows:
Apply errors:
This seems to be because "rolearn" is empty.
Checklist