feat: Add tags on network interfaces

[alexmnyc]

PR o'clock

Description

Resolves #1361

Checklist

• CI tests are passing
• README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation

[alexmnyc]

All resources created by the module must be tagged consistently. This PR addresses ENI lack of tags

[barryib]

Thanks @alexmnyc for your contribution.

[alexmnyc]

@barryib my pleasure

[jan-ludvik-deltatre]

Hi @alexmnyc, I am getting this. Am I doing something wrong?

expected tag_specifications.2.resource_type to be one of [instance volume spot-instances-request elastic-gpu], got network-interface

[barryib]

Hi @alexmnyc, I am getting this. Am I doing something wrong?

expected tag_specifications.2.resource_type to be one of [instance volume spot-instances-request elastic-gpu], got network-interface

It sounds like I merged this, and it's not supported 🤦‍♂️

https://docs.aws.amazon.com/AWSEC2/latest/APIReference/API_LaunchTemplateTagSpecificationRequest.html

The type of resource to tag. Currently, the resource types that support tagging on creation are instance and volume.

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/launch_template#tag-specifications

The type of resource to tag. Valid values are instance, volume, elastic-gpu and spot-instances-request.

@jan-ludvik-deltatre @alexmnyc can you confirm please.

[lisfo4ka]

But shouldn't CI fail on this before the merge?

  tag_specifications {
    resource_type = "network-interface"

[barryib]

But shouldn't CI fail on this before the merge?

  tag_specifications {
    resource_type = "network-interface"

The CI only terraform validate. I also thought that this kind of bug will be catched during that phase, but found that even terraform plan don't.

This is a ongoing feature in the terraform-provider-aws. Here the related PR hashicorp/terraform-provider-aws#18033.

Until that PR get merged, I'm reverting this.

[alexmnyc]

[alexmnyc]

I see, it seems like aws provider is out of date and doesn't support it. Is that the issue?

[barryib]

I see, it seems like aws provider is out of date and doesn't support it. Is that the issue?

Yes. Please see my previous comment.

For the revert could you review #1407

[barryib]

Reverted in v17.0.2

[barryib]

@alexmnyc can you please follow hashicorp/terraform-provider-aws#18033 and re-open a PR as soon as it get released in the provider ?

Thanks everyone for your help.

[alexmnyc]

Thanks @barryib Will do. My bad. One would think it would be a pass through value given the AWS spec

[github-actions]

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.