feat: Add multiple selectors on the creation of Fargate profile #1378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
barryib
force-pushed
the
Lena-nfb-multiple-selectors
branch
from
2cb42a4 to
d0fe456
Compare
barryib
force-pushed
the
Lena-nfb-multiple-selectors
branch
from
f982b2a to
bdf85f3
Compare
ArchiFleKs
pushed a commit
to ArchiFleKs/terraform-aws-eks
that referenced
this pull request
Jun 1, 2021
…aform-aws-modules#1378) BREAKING CHANGES: To support multiple selectors for Fargate profiles, we introduced the `selectors` argument which is a list of map. This will break previous configuration with a single selector `namespace` and `labels`. You'll need to rewrite your configuration to use the `selectors` argument. See [examples](https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/examples/fargate/main.tf) dans [docs](https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/modules/fargate/README.md) for details. Co-authored-by: Lena <lena.mantziou@nationwide.co.uk>
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
This is taken from #1158.
Thanks @Lena-nfb for his work.
Resolves #1367
Resolves #1155
BREAKING CHANGES: To support multiple selectors for Fargate profiles, we introduced the
selectorsargument which is a list of map. This will break previous configuration with a single selectornamespaceandlabels. You'll need to rewrite your configuration to use theselectorsargument. See examples dans docs for details.Checklist