Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to specify tags for worker security groups #1711

Closed
mikesir87 opened this issue Dec 6, 2021 · 2 comments · Fixed by #1680
Closed

Ability to specify tags for worker security groups #1711

mikesir87 opened this issue Dec 6, 2021 · 2 comments · Fixed by #1680

Comments

@mikesir87
Copy link

Is your request related to a problem? Please describe.

When using Karpenter, it scans and automatically selects a security group that has the kubernetes.io/cluster/<cluster-name> tag to apply to the launch template it creates. But, since EKS automatically creates another security group with the same tag (and any automatically created by load balancers), there's a good chance that it doesn't select the right one. This obviously causes nodes to launch with the incorrect role and can't connect to the cluster, talk to each other, etc.

Describe the solution you'd like.

I'd like the ability to specify tags specifically for the worker security group. But, I know that's not something this module has generally supported (one-off tags). And it doesn't make sense to specify it in the higher-level tags variable, as I don't need to add something to every security group.

Describe alternatives you've considered.

We've thought about simply managing our own security group and replicating all of the security group rules. But, it would be nice if we didn't need to maintain that ourselves.

Additional context

I'm happy to submit a PR based on any sort of direction/input on how you'd like to solve this.

@antonbabenko
Copy link
Member

This issue has been resolved in version 18.0.0 🎉

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants