Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add additional output for OIDC provider (issuer URL without leading https://) #1870

Merged

Conversation

bryantbiggs
Copy link
Member

Description

  • Add additional output for OIDC provider (issuer URL without leading https://)

Motivation and Context

  • Avoid duplicating logic of stripping leading https:// in multiple places and match what is shown in the console. If you log into the console and navigate to IAM -> Identity providers -> select an OIDC provider, in the top left under Summary you will see this same value stored under the field Provider; hence the output name here is simply oidc_provider

Breaking Changes

  • No

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

outputs.tf Outdated Show resolved Hide resolved
@antonbabenko antonbabenko merged commit d3b6847 into terraform-aws-modules:master Feb 11, 2022
antonbabenko pushed a commit that referenced this pull request Feb 11, 2022
## [18.6.0](v18.5.1...v18.6.0) (2022-02-11)

### Features

* Add additional output for OIDC provider (issuer URL without leading `https://`) ([#1870](#1870)) ([d3b6847](d3b6847))
@antonbabenko
Copy link
Member

This PR is included in version 18.6.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants