feat: Add create_before_destroy lifecycle hook to security groups created
#1985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
pushed a commit
that referenced
this pull request
Apr 4, 2022
## [18.19.0](v18.18.0...v18.19.0) (2022-04-04) ### Features * Add `create_before_destroy` lifecycle hook to security groups created ([#1985](#1985)) ([6db89f8](6db89f8))
|
This PR is included in version 18.19.0 🎉 |
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Apr 26, 2022
## [18.19.0](terraform-aws-modules/terraform-aws-eks@v18.18.0...v18.19.0) (2022-04-04) ### Features * Add `create_before_destroy` lifecycle hook to security groups created ([terraform-aws-modules#1985](terraform-aws-modules#1985)) ([6db89f8](terraform-aws-modules@6db89f8))
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
it-without-politics
pushed a commit
to it-without-politics/terraform-aws-eks
that referenced
this pull request
May 23, 2022
## [18.19.0](terraform-aws-modules/terraform-aws-eks@v18.18.0...v18.19.0) (2022-04-04) ### Features * Add `create_before_destroy` lifecycle hook to security groups created ([terraform-aws-modules#1985](terraform-aws-modules#1985)) ([6db89f8](terraform-aws-modules@6db89f8))
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
## [18.19.0](terraform-aws-modules/terraform-aws-eks@v18.18.0...v18.19.0) (2022-04-04) ### Features * Add `create_before_destroy` lifecycle hook to security groups created ([#1985](terraform-aws-modules/terraform-aws-eks#1985)) ([acfb22e](terraform-aws-modules/terraform-aws-eks@acfb22e))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
create_before_destroylifecycle hook to security groups createdMotivation and Context
create_security_grouptofalseafter it defaults totrueand has been created, the security group is unable to detach and delete. Reading through the numerous issues, I am hopeful this might work for the autoscaling groups. If not, it should be in place regardless for when users re-name their security groups and they need to be re-createdBreaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request