Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Correct 'iam_role_user_name_prefix' variable type 'string' -> 'bool' #2000

Conversation

krrrr38
Copy link
Contributor

@krrrr38 krrrr38 commented Apr 9, 2022

Signed-off-by: krrrr38 k.kaizu38@gmail.com

Description

fix iam_role_user_name_prefix type as bool

Motivation and Context

iam_role_user_name_prefix should be bool

Breaking Changes

N/A

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Signed-off-by: krrrr38 <k.kaizu38@gmail.com>
@krrrr38 krrrr38 force-pushed the fix-iam-role-use-name-prefix-bool branch from efdaa76 to 0e6fe8f Compare April 9, 2022 11:44
@bryantbiggs
Copy link
Member

good catch @krrrr38 ! could you update your PR title to something like fix: Correct 'iam_role_user_name_prefix' variable type 'string' -> 'bool'

@krrrr38 krrrr38 changed the title fix: iam_role_user_name_prefix type as bool fix: Correct 'iam_role_user_name_prefix' variable type 'string' -> 'bool' Apr 9, 2022
@krrrr38
Copy link
Contributor Author

krrrr38 commented Apr 9, 2022

@bryantbiggs thanks, updated the title 🙆‍♀️

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @krrrr38 - good to go @antonbabenko 👍🏽

@antonbabenko antonbabenko merged commit c576aad into terraform-aws-modules:master Apr 9, 2022
antonbabenko pushed a commit that referenced this pull request Apr 9, 2022
### [18.20.1](v18.20.0...v18.20.1) (2022-04-09)

### Bug Fixes

* iam_role_user_name_prefix type as an bool ([#2000](#2000)) ([c576aad](c576aad))
@antonbabenko
Copy link
Member

This PR is included in version 18.20.1 🎉

spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Apr 26, 2022
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Apr 26, 2022
it-without-politics pushed a commit to it-without-politics/terraform-aws-eks that referenced this pull request May 23, 2022
it-without-politics pushed a commit to it-without-politics/terraform-aws-eks that referenced this pull request May 23, 2022
baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants