-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add create_autoscaling_group
option and extra outputs
#2067
feat: Add create_autoscaling_group
option and extra outputs
#2067
Conversation
Thanks for the PR @sethpollack - I think the addition of |
Missed this - already there, thanks! |
@bryantbiggs No spotinst doesn't use a launch template, you need to provide those values: https://registry.terraform.io/providers/spotinst/spotinst/latest/docs/resources/ocean_aws |
create_autoscaling_group
option and extra outputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
## [18.21.0](v18.20.5...v18.21.0) (2022-05-12) ### Features * Add `create_autoscaling_group` option and extra outputs ([#2067](#2067)) ([58420b9](58420b9))
This PR is included in version 18.21.0 🎉 |
Thanks! |
## [18.21.0](terraform-aws-modules/terraform-aws-eks@v18.20.5...v18.21.0) (2022-05-12) ### Features * Add `create_autoscaling_group` option and extra outputs ([terraform-aws-modules#2067](terraform-aws-modules#2067)) ([58420b9](terraform-aws-modules@58420b9))
## [18.21.0](terraform-aws-modules/terraform-aws-eks@v18.20.5...v18.21.0) (2022-05-12) ### Features * Add `create_autoscaling_group` option and extra outputs ([terraform-aws-modules#2067](terraform-aws-modules#2067)) ([58420b9](terraform-aws-modules@58420b9))
## [18.21.0](terraform-aws-modules/terraform-aws-eks@v18.20.5...v18.21.0) (2022-05-12) ### Features * Add `create_autoscaling_group` option and extra outputs ([#2067](terraform-aws-modules/terraform-aws-eks#2067)) ([f0d7e09](terraform-aws-modules/terraform-aws-eks@f0d7e09))
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
adds
create_autoscaling_group
toself-managed-node-groups
and addsimage_id
anduser_data
outputs.Motivation and Context
Currently to use this module with something like karpenter or spotinst you need to create a nodegroup and scale it down in order to have the iam role, userdata, etc. created for you.
You can then do something like this to get all the data you need:
This PR eliminates the extra hoops by adding the
create_autoscaling_group
option and exporting theimage_id
anduser_data
.