Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorporate "Tags for the ASG to support cluster-autoscaler scale up from 0" example into managed node groups #2255

Closed
flowinh2o opened this issue Oct 3, 2022 · 3 comments

Comments

@flowinh2o
Copy link

Support for managed node groups to scale from 0 via tagging the associate node groups

It would be nice to incorporate the tagging of autoscaling groups that is already in the included example https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/examples/eks_managed_node_group/main.tf#L674. I don't think the changes are going to happen on the AWS side since the ticket has been open for almost 2 years now. aws/containers-roadmap#724

Looks like the work is pretty much done here so why not just add another variable to enable tagging propagation?

Thank you.

@bryantbiggs
Copy link
Member

#1558 (comment)

@bryantbiggs
Copy link
Member

closing since there isn't a viable solution to incorporate this into the module - see linked comment above where this was attempted

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants