fix: Call to lookup() closed too early, breaks sg rule creation in cluster sg if custom source sg is defined. #2319
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… if custom source sg is defined.
AdamStaudt
changed the title
AdamStaudt
changed the title
…ity group rule and add test cases
bryantbiggs
approved these changes
Dec 6, 2022
antonbabenko
pushed a commit
that referenced
this pull request
Dec 6, 2022
### [19.0.1](v19.0.0...v19.0.1) (2022-12-06) ### Bug Fixes * Call to lookup() closed too early, breaks sg rule creation in cluster sg if custom source sg is defined. ([#2319](#2319)) ([7bc4a27](7bc4a27))
|
This PR is included in version 19.0.1 🎉 |
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Jan 4, 2023
…uster sg if custom source sg is defined. (terraform-aws-modules#2319) Co-authored-by: Bryant Biggs <bryantbiggs@gmail.com>
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Jan 4, 2023
### [19.0.1](terraform-aws-modules/terraform-aws-eks@v19.0.0...v19.0.1) (2022-12-06) ### Bug Fixes * Call to lookup() closed too early, breaks sg rule creation in cluster sg if custom source sg is defined. ([terraform-aws-modules#2319](terraform-aws-modules#2319)) ([7bc4a27](terraform-aws-modules@7bc4a27))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
fixed typo in nested lookup() calls in
aws_security_group_rule.clusterresourceMotivation and Context
If a security group ID is supplied in the
source_security_group_idparameter tocluster_security_group_additional_rules, the ternary operator will break, as the nested lookup() function will return a string rather than a bool.Breaking Changes
No breaking changes.
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestChange was tested on production code within our organisation, which creates a SG rule with an external SG as its source. The same input worked under v18 and broke under v19.