feat: Allow to pass prefix for rule names #2437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerlh
changed the title
omerlh
force-pushed
the
feat/rule-name-prefix-support
branch
from
c26e178 to
41e4cee
Compare
bryantbiggs
reviewed
Feb 4, 2023
bryantbiggs
reviewed
Feb 4, 2023
bryantbiggs
reviewed
Feb 4, 2023
omerlh
force-pushed
the
feat/rule-name-prefix-support
branch
from
41e4cee to
bab5cca
Compare
omerlh
force-pushed
the
feat/rule-name-prefix-support
branch
from
bab5cca to
4d99f04
Compare
bryantbiggs
approved these changes
Feb 7, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Feb 7, 2023
## [19.7.0](v19.6.0...v19.7.0) (2023-02-07) ### Features * Allow to pass prefix for rule names ([#2437](#2437)) ([68fe60f](68fe60f))
|
This PR is included in version 19.7.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added variable to control the prefix used for event bridge rules.
Motivation and Context
We are trying to use ABAC to control permissions of our CI/CD, using
ResourceTagIAM condition wherever possible. It seems that EventBridge IAM permissions does not allow that so I would like to limit permissions by resource ARN, and for that I would like to control the prefix used for all rules - so I could give our CI/CD tool permissions to control only rules matching this prefix.Breaking Changes
How Has This Been Tested?
(Still testing, opened for feedback because it's my first PR)
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request