Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pass the primary_ipv6 argument to the AWS provider. #3098

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

achernev
Copy link
Contributor

Description, motivation, context

The 5.58.0 release of the Terraform AWS Provider now exposes the PrimaryIpv6 launch template network interfaces parameter via this PR. This parameter causes the first globally-unique IPv6 address to become the primary IPv6 address of instances launched using the template. This is necessary for dual-stack EKS clusters, where the ingress controller's IPv6 address needs to propagate to the ALB during target registration.

The current PR adds the primary_ipv6 flag when used as follows:

module "eks" {
  source  = "terraform-aws-modules/eks/aws"

  # ...
  eks_managed_node_group_defaults = {
    # This is only supported by versions of the terraform-aws-provider >= 5.58.0.
    network_interfaces = [{ primary_ipv6 = true }]
  }
}

Breaking Changes

None.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request
% docker run -e "USERID=$(id -u):$(id -g)" -v $(pwd):/lint -w /lint ghcr.io/antonbabenko/pre-commit-terraform:latest run -a
[INFO] Initializing environment for https://github.com/antonbabenko/pre-commit-terraform.
[INFO] Initializing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Installing environment for https://github.com/pre-commit/pre-commit-hooks.
[INFO] Once installed this environment will be reused.
[INFO] This may take a few minutes...
Terraform fmt............................................................Passed
Terraform docs...........................................................Passed
Terraform validate with tflint...........................................Passed
Terraform validate.......................................................Passed
check for merge conflicts................................................Passed
fix end of files.........................................................Passed
trim trailing whitespace.................................................Passed
mixed line ending........................................................Passed

I am currently using the examples/eks-managed-node-group/eks-bottlerocket.tf in conjunction with the supplied changes (and additional modifications) in a production environment.

@achernev achernev changed the title Pass the primary_ipv6 argument to the AWS provider. [feat] Pass the primary_ipv6 argument to the AWS provider. Jul 12, 2024
@achernev achernev changed the title [feat] Pass the primary_ipv6 argument to the AWS provider. feat: Pass the primary_ipv6 argument to the AWS provider. Jul 12, 2024
@bryantbiggs bryantbiggs merged commit e1bb8b6 into terraform-aws-modules:master Jul 15, 2024
19 checks passed
antonbabenko pushed a commit that referenced this pull request Jul 15, 2024
## [20.19.0](v20.18.0...v20.19.0) (2024-07-15)

### Features

* Pass the `primary_ipv6` argument to the AWS provider. ([#3098](#3098)) ([e1bb8b6](e1bb8b6))
@antonbabenko
Copy link
Member

This PR is included in version 20.19.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants