fix: Add vpc_config.cluster_security_group output as primary cluster security group id
#828
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slimm609
changed the title
barryib
suggested changes
Apr 22, 2020
There was a problem hiding this comment.
@slimm609 Thanks again for pushing this. Can you please add some description on cluster_security_group_id as @dpiddockcmp proposed #799 (comment) ?
barryib
approved these changes
Apr 23, 2020
dpiddockcmp
approved these changes
Apr 23, 2020
barryib
changed the title
vpc_config.cluster_security_group output as primary cluster security group id
|
Awsome. Thanks @slimm609 and @dpiddockcmp. |
4 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Add cluster security group output as "primary cluster security group id".
This is a short term fix to provide the cluster security group id until 1.16 is released and node groups can be refactored to move cluster security group id to additional security group id. With 1.16 release, 1.13 will no longer be maintained which will cause the issues with backwards compatibility to go away because the old node groups will no longer be supported.
Description
#799
and
#792
Checklist