-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add kubernetes standard labels to avoid manual mistakes on the managed aws-auth
configmap
#989
feat: Add kubernetes standard labels to avoid manual mistakes on the managed aws-auth
configmap
#989
Conversation
@gillg CI is failing as you must change PR titlle as per https://github.com/terraform-aws-modules/terraform-aws-eks/blob/master/.github/CONTRIBUTING.md#semantic-pull-requests I belive this will be |
aws-auth
configmap
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gillg can you please rebase your branch from master and re-generate the terraform docs to fix the CI.
d5ff0d4
to
53807c9
Compare
Everything is OK |
53807c9
to
4f25f5d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @gillg for your contribution.
…managed `aws-auth` configmap (terraform-aws-modules#989)
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add labels to avoid manual mistakes on managed configmap. It adds 2 labels :
By this way and "standard" managed-by label, we know this file is provided and enforced by terraform. You should not edit it manualy.
Checklist