From 0e65fcf18f945e8dc281e9ca9dddeadc44b805c5 Mon Sep 17 00:00:00 2001 From: Peter Parada Date: Tue, 29 Dec 2020 19:47:03 +0100 Subject: [PATCH 1/3] Fix typo in README --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index f46ba5cec8..e33c5d9c92 100644 --- a/README.md +++ b/README.md @@ -168,7 +168,7 @@ MIT Licensed. See [LICENSE](https://github.com/terraform-aws-modules/terraform-a | Name | Description | Type | Default | Required | |------|-------------|------|---------|:--------:| | attach\_worker\_cni\_policy | Whether to attach the Amazon managed `AmazonEKS_CNI_Policy` IAM policy to the default worker IAM role. WARNING: If set `false` the permissions must be assigned to the `aws-node` DaemonSet pods via another method or nodes will not be able to join the cluster. | `bool` | `true` | no | -| aws\_auth\_additional\_labels | Additionnal kubernetes labels applied on aws-auth ConfigMap | `map(string)` | `{}` | no | +| aws\_auth\_additional\_labels | Additional kubernetes labels applied on aws-auth ConfigMap | `map(string)` | `{}` | no | | cluster\_create\_endpoint\_private\_access\_sg\_rule | Whether to create security group rules for the access to the Amazon EKS private API server endpoint. | `bool` | `false` | no | | cluster\_create\_security\_group | Whether to create a security group for the cluster or attach the cluster to `cluster_security_group_id`. | `bool` | `true` | no | | cluster\_create\_timeout | Timeout value when creating the EKS cluster. | `string` | `"30m"` | no | From cc3661f886f1a273c4e325f56d13cbb07089f203 Mon Sep 17 00:00:00 2001 From: Peter Parada Date: Tue, 29 Dec 2020 19:52:52 +0100 Subject: [PATCH 2/3] Fix typos in CONTRIBUTING --- .github/CONTRIBUTING.md | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/CONTRIBUTING.md b/.github/CONTRIBUTING.md index 5ab6a91687..65df33743e 100644 --- a/.github/CONTRIBUTING.md +++ b/.github/CONTRIBUTING.md @@ -8,18 +8,18 @@ Please note we have a code of conduct, please follow it in all your interactions ## Pull Request Process 1. Ensure any install or build dependencies are removed before the end of the layer when doing a build. -2. Update the README.md with details of changes to the interface, this includes new environment variables, exposed ports, useful file locations and container parameters. -3. Once all outstanding comments and checklist items have been addressed, your contribution will be merged! Merged PRs will be included in the next release. The terraform-aws-eks mainteners takes care of updating the CHANGELOG as they merge. +2. Update the README.md with details of changes to the interface, this includes new environment variables, exposed ports, useful file locations, and container parameters. +3. Once all outstanding comments and checklist items have been addressed, your contribution will be merged! Merged PRs will be included in the next release. The terraform-aws-eks maintainers take care of updating the CHANGELOG as they merge. ## Checklists for contributions -- [ ] Add [sementics prefix](#semantic-pull-requests) to your PR or Commits (at leats one of your commit groups) +- [ ] Add [semantics prefix](#semantic-pull-requests) to your PR or Commits (at least one of your commit groups) - [ ] CI tests are passing - [ ] README.md has been updated after any changes to variables and outputs. See https://github.com/terraform-aws-modules/terraform-aws-eks/#doc-generation ## Semantic Pull Requests -To generate changelog, Pull Requests or Commits must have sementic and must follow conventional specs below: +To generate changelog, Pull Requests or Commits must have semantic and must follow conventional specs below: - `feat:` for new features - `fix:` for bug fixes From 271fec1191756869984fdd99da9b9dc90dbe50e9 Mon Sep 17 00:00:00 2001 From: Peter Parada Date: Wed, 30 Dec 2020 11:36:36 +0100 Subject: [PATCH 3/3] Fix typo in variables.tf --- variables.tf | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/variables.tf b/variables.tf index 9ff70f9a99..496b4890eb 100644 --- a/variables.tf +++ b/variables.tf @@ -50,7 +50,7 @@ variable "manage_aws_auth" { } variable "aws_auth_additional_labels" { - description = "Additionnal kubernetes labels applied on aws-auth ConfigMap" + description = "Additional kubernetes labels applied on aws-auth ConfigMap" default = {} type = map(string) }