Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add variable cluster_primary_security_group_tags for cluster primary security group tags #2586

Conversation

balonik
Copy link

@balonik balonik commented Apr 24, 2023

Description

Add new input variable cluster_primary_security_group_tags to specifically set cluster primary security group tags.

Motivation and Context

Alternative to #2249 which was later reverted in #2250.

I am trying to apply AWS provider default tags on Cluster primary security group, I have used cluster_tags with data.aws_default_tags data source. But this is causing tags changes to be planned/applied every run, because of hashicorp/terraform-provider-aws#18311 and fact that cluster_tags is also used in aws_eks_cluster resource. Using dedicated variable I can do something like:

cluster_primary_security_group_tags = data.aws_default_tags.current.tags instead of cluster_tags = data.aws_default_tags.current.tags.

Having a dedicated variable also helps in cases where tags on EKS cluster and SG must differ.

Next step would be to remove var.cluster_tags from the SG.

Breaking Changes

N/A

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@balonik balonik changed the title add input for cluster primary security group tags feat: add input for cluster primary security group tags Apr 24, 2023
@balonik balonik changed the title feat: add input for cluster primary security group tags feat: Add variable cluster_primary_security_group_tags for cluster primary security group tags Apr 24, 2023
@bryantbiggs
Copy link
Member

as stated in #2577, this is not a change we are going to support at this time

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants