Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle unencrypted secrets #139

Merged
merged 3 commits into from
Mar 4, 2021
Merged

fix: handle unencrypted secrets #139

merged 3 commits into from
Mar 4, 2021

Conversation

nikolay
Copy link
Contributor

@nikolay nikolay commented Mar 4, 2021

Description

There are use cases when encryption is not possible and these are not handled properly right now.

Motivation and Context

Sometimes internal accounts are created and they never leave Terraform and encryption is not possible due to the lack of decryption functionality within Terraform.

Breaking Changes

When not appropriate, Keybase commands will just be null, which could be extended further to check if a regular PGP key is used and not a Keybase one.

@nikolay nikolay marked this pull request as ready for review March 4, 2021 19:27
@antonbabenko antonbabenko merged commit 3d0509b into terraform-aws-modules:master Mar 4, 2021
@antonbabenko
Copy link
Member

Looks good! Thank you for this improvement!

v3.11.0 has been just released.

@nikolay nikolay deleted the patch-1 branch July 30, 2022 02:05
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants