Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support tags to additional IAM modules #144

Conversation

edgarsandi
Copy link
Contributor

Description

Add tags variable:

aws_iam_instance_profile released in TerraformAWS provider v3.34 on PR #17962
aws_iam_policy released in terraform-aws-provider v3.35 on PR #18276

Motivation and Context

I need to tag all (or at least I would like that) resources provisioned, Its help me with cost management and organization

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@antonbabenko
Copy link
Member

Looks good, but please update versions.tf in each module and example affected with the correct minimum version of the AWS provider.

@dogfish182 dogfish182 mentioned this pull request Apr 14, 2021
1 task
@edgarsandi
Copy link
Contributor Author

Hello @antonbabenko, I think there was a problem with this merge, I didn't find these changes in the master

@antonbabenko
Copy link
Member

@edgarsandi I merged master into this feature branch but there are a couple of remaining issues (see my last comment) that have to be fixed before this PR is merged.

@edgarsandi edgarsandi force-pushed the add-support-tags-to-additional-iam-modules branch from af82313 to 49fbd72 Compare May 2, 2021 22:50
@edgarsandi
Copy link
Contributor Author

Hi @antonbabenko!

Have any further reviews pending in this PR?

[]'s

@antonbabenko antonbabenko changed the title Add support tags to additional iam modules feat: Add support tags to additional IAM modules May 3, 2021
@antonbabenko antonbabenko merged commit 97af55f into terraform-aws-modules:master May 3, 2021
@antonbabenko
Copy link
Member

Thanks @edgarsandi !

v4.1.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants