Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare code for 0.15 #146

Closed
mbevc1 opened this issue Apr 14, 2021 · 7 comments · Fixed by #148
Closed

Prepare code for 0.15 #146

mbevc1 opened this issue Apr 14, 2021 · 7 comments · Fixed by #148

Comments

@mbevc1
Copy link

mbevc1 commented Apr 14, 2021

0.15 was released and in order to use modules here we'd need to remove deprecated syntax like: https://github.com/terraform-aws-modules/terraform-aws-iam/blob/master/modules/iam-assumable-role/main.tf#L2

@antonbabenko
Copy link
Member

Sure, please make a PR :)

@andormarkus
Copy link

Hi @mbevc1

outputs are causing errors as well.

│ Error: Output refers to sensitive values
│ 
│   on .terraform/modules/this/modules/iam-user/outputs.tf line 43:
│   43: output "this_iam_access_key_secret" {
│ 
│ Expressions used in outputs can only refer to sensitive values if the
│ sensitive attribute is true.
╵
╷
│ Error: Output refers to sensitive values
│ 
│   on .terraform/modules/this/modules/iam-user/outputs.tf line 58:
│   58: output "this_iam_access_key_ses_smtp_password_v4" {
│ 
│ Expressions used in outputs can only refer to sensitive values if the
│ sensitive attribute is true.
╵

@mbevc1
Copy link
Author

mbevc1 commented Apr 14, 2021

I'll try to open a PR in next few days - time permitting :)

@andormarkus
Copy link

Hi @antonbabenko

Legacy functions
Changing the list to tolist function will not break the module because that function is available from v0.12.0 and the module is supporting terraform from v0.12.6

Sensitive Output Values
The sensitive output are causing backwards compatibility issues. It was introduced in v0.14.0 and in v0.15.0 they made it more sensitive [source].

We got two options:

  • sensitive = true in output - need v0.14.0
  • nonsensitive function - needs v0.15.0

To solving the sensitive output values problem we need to raise the minimum supported version of the module. Terraform suggest to raise the minimum supported version to v0.15.0
We need guidance in this manner.

@antonbabenko
Copy link
Member

Setting sensitive = true on outputs seems to be the best option that works for all supported versions (starting from Terraform 0.12.6).

Fixed in #148.

v3.15.0 has been just released.

@mbevc1
Copy link
Author

mbevc1 commented Apr 15, 2021

Beat me to it. Thanks @antonbabenko 🥳

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants