Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added support for trusted_role_actions for MFA in iam-assumable-role #171

Merged
merged 1 commit into from
Oct 14, 2021

Conversation

RafPe
Copy link
Contributor

@RafPe RafPe commented Oct 14, 2021

Fixes #152

Description

This is a small patch change discussed with @antonbabenko to make sure there is no discrepancy when using trusted_role_actions with or without MFA

Motivation and Context

Consistent module behaviour based on inputs

Breaking Changes

none

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@antonbabenko antonbabenko changed the title Adds trusted_role_actions for MFA in Iam_assumable_role feat: Added support for trusted_role_actions for MFA in iam-assumable-role Oct 14, 2021
@antonbabenko antonbabenko merged commit dc363d2 into terraform-aws-modules:master Oct 14, 2021
@antonbabenko
Copy link
Member

Thanks, @RafPe !

v4.7.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

iam-assumable-role: support sts:TagSession or custom assume policy
2 participants