-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Make PGP Key Optional in All Cases #205
feat: Make PGP Key Optional in All Cases #205
Conversation
The pgp_key argument in the aws_iam_user_login_profile resource is optional with a sufficently new provider.
The pgp_key argument is optional since 4.1.0
Thanks for the PR @p0fi - can you update the docs by running |
Sorry for the dumb question, but how to do this? I checked brew and found a package called |
ah yes, we should probably add that. Here is a link for now https://github.com/antonbabenko/pre-commit-terraform#how-to-install |
Opened a PR to add this info FYI - terraform-aws-modules/.github#22 |
Thanks for the link, the docker image worked well 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the PR @p0fi - good to go @antonbabenko 👍🏽
## [4.17.0](v4.16.0...v4.17.0) (2022-03-26) ### Features * Make PGP Key Optional in All Cases ([#205](#205)) ([4242512](4242512))
This PR is included in version 4.17.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This will make the
pgp_key
argument optional in all configurations and add the unencrypted user password to the list of outputs. This will also raise the minimum requiredaws
provider version to4.1.0
Motivation and Context
When trying to create an iam user without a
pgp_key
but with aniam_user_login_profile
the creation would fail.Since version
4.1.0
of theaws
provider thepgp_key
argument of the resourceaws_iam_user_login_profile
is optional. Thus the constraint that apgp_key
is required when usingcreate_iam_user_login_profile = true
is not needed anymore.👉 Terraform docs for
aws_iam_user_login_profile
(4.1.0
)Breaking Changes
No
How Has This Been Tested?