Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update role_name default to null #319

Merged

Conversation

magreenbaum
Copy link
Member

Description

role_name conflicts with role_name_prefix in the iam-assumable-role module.

Motivation and Context

#318

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs bryantbiggs merged commit 0baa2c1 into terraform-aws-modules:master Dec 10, 2022
antonbabenko pushed a commit that referenced this pull request Dec 10, 2022
### [5.9.2](v5.9.1...v5.9.2) (2022-12-10)

### Bug Fixes

* Update `role_name` default to `null` ([#319](#319)) ([0baa2c1](0baa2c1))
@antonbabenko
Copy link
Member

This PR is included in version 5.9.2 🎉

@magreenbaum magreenbaum deleted the fix_role_name_default branch December 11, 2022 14:01
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants