Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added description for roles when using iam-group-with-policies #33

Merged
merged 1 commit into from
Aug 21, 2019
Merged

Added description for roles when using iam-group-with-policies #33

merged 1 commit into from
Aug 21, 2019

Conversation

mogaal
Copy link
Contributor

@mogaal mogaal commented Aug 1, 2019

Description

I got into a limitation regarding set descriptions for roles used inside iam-group-with-policies module.

I added the possibility of set descriptions for roles using a terraform lookup function, which doesn't affect the behaviour because it sets to null description (basically not set) in case user doesn't specify description field inside the lits(maps)

@antonbabenko antonbabenko merged commit 5cb8959 into terraform-aws-modules:master Aug 21, 2019
@antonbabenko
Copy link
Member

Thanks @mogaal for this PR.

v2.3.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants