feat: Add support for AWS Gateway controller (VPC Lattice) to IRSA module #378
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
pending name clarification |
bryantbiggs
force-pushed
the
feat/gateway-api-controller
branch
from
9e18878 to
cd08216
Compare
bryantbiggs
changed the title
| data "aws_iam_policy_document" "api_gateway_controller" { | ||
| count = var.create_role && var.attach_api_gateway_controller_policy ? 1 : 0 | ||
|
|
||
| # https://github.com/aws/aws-application-networking-k8s/blob/main/examples/recommended-inline-policy.json |
There was a problem hiding this comment.
In the comment, does it make sense to point to a tag/release instead of a moving main branch?
The rest LGTM.
There was a problem hiding this comment.
good point - corrected in 5ca15c6
…h EKS module output
antonbabenko
approved these changes
May 22, 2023
antonbabenko
pushed a commit
that referenced
this pull request
May 22, 2023
## [5.20.0](v5.19.0...v5.20.0) (2023-05-22) ### Features * Add support for AWS Gateway controller (VPC Lattice) to IRSA module ([#378](#378)) ([fdee003](fdee003))
|
This PR is included in version 5.20.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
cluster_autoscaler_cluster_namesandkarpenter_controller_cluster_namewhich shadow their current equivalents (cluster_autoscaler_cluster_idsandkarpenter_controller_cluster_id). Users should now use thecluster_nameoutput from the EKS module (starting in v19.x) sincecluster_idnow has a different meaning on local clusters on Outposts. This change starts to correct that behavior and align the inputs/outputs to reduce confusion but without breaking compatibility. The_idequivalents will be removed at the next breaking changeMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request