Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added permissions to list zone tags in iam-role-for-service-accounts-eks module #394

Merged

Conversation

jalaziz
Copy link
Contributor

@jalaziz jalaziz commented Jun 23, 2023

Description

When using the --aws-zone-tags filter feature of external-dns, route53:ListTagsForResource permissions are required.

Without it, external-dns will fail to start.

Motivation and Context

This change adds the necessary permissions required for external-dns to start when using the --aws-zone-tags filter.

Breaking Changes

No breaking changes.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have applied the changes from my fork and confirmed external-dns starts successfully
  • I have executed pre-commit run -a on my pull request

When using the `--aws-zone-tags` filter feature of external-dns,
`route53:ListTagsForResource` permissions are required.

Without it, external-dns will fail to start.
@antonbabenko antonbabenko changed the title fix: Give external-dns permissions to list zone tags fix: Added permissions to list zone tags in iam-role-for-service-accounts-eks module (required for external-dns) Jun 23, 2023
@antonbabenko antonbabenko changed the title fix: Added permissions to list zone tags in iam-role-for-service-accounts-eks module (required for external-dns) fix: Added permissions to list zone tags in iam-role-for-service-accounts-eks module Jun 23, 2023
@antonbabenko antonbabenko changed the title fix: Added permissions to list zone tags in iam-role-for-service-accounts-eks module feat: Added permissions to list zone tags in iam-role-for-service-accounts-eks module Jun 23, 2023
@antonbabenko antonbabenko merged commit 740945f into terraform-aws-modules:master Jun 23, 2023
antonbabenko pushed a commit that referenced this pull request Jun 23, 2023
## [5.21.0](v5.20.0...v5.21.0) (2023-06-23)

### Features

* Added permissions to list zone tags in iam-role-for-service-accounts-eks module ([#394](#394)) ([740945f](740945f))
@antonbabenko
Copy link
Member

This PR is included in version 5.21.0 🎉

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants