feat: Add variable for adding statement for secretsmanager:CreateSecret
#414
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aschaber1
force-pushed
the
aws_secrets_manager_create
branch
from
09063ad to
754a2b8
Compare
aschaber1
changed the title
secretsmanager:CreateSecretsecretsmanager:CreateSecret
aschaber1
force-pushed
the
aws_secrets_manager_create
branch
from
754a2b8 to
4a7227d
Compare
bryantbiggs
approved these changes
Aug 23, 2023
antonbabenko
pushed a commit
that referenced
this pull request
Aug 23, 2023
## [5.29.0](v5.28.0...v5.29.0) (2023-08-23) ### Features * Add variable for adding statement for `secretsmanager:CreateSecret` ([#414](#414)) ([24996cd](24996cd))
|
This PR is included in version 5.29.0 🎉 |
4 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add variable for configuring additional permissions for the IRSA Role, in order to allow CreateSecret.
Motivation and Context
Allow for usage of PushSecret, which requires CreateSecret access to AWS Secret Manager.
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request