Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add support for Amazon CloudWatch Observability IRSA role #446

Conversation

JoeNorth
Copy link
Contributor

Description

feat: Add support for Amazon CloudWatch Observability IRSA role

Motivation and Context

Adding support for creating IRSA role for Amazon CloudWatch Observability add-on

Breaking Changes

N/A

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@JoeNorth
Copy link
Contributor Author

Currently running into an issue in testing these changes. Attempting to deploy example/am-role-for-service-accounts-eks results in the following error:

│ Error: Invalid template interpolation value
│ 
│   on ../../modules/iam-role-for-service-accounts-eks/main.tf line 10, in locals:
│   10:   role_name_condition = var.role_name != null ? var.role_name : "${var.role_name_prefix}*"
│     ├────────────────
│     │ var.role_name_prefix is null
│ 
│ The expression result is null. Cannot include a null value in a string template.

This issue is also present in the master branch. @bryantbiggs thoughts?

@bryantbiggs bryantbiggs force-pushed the feat/amazon_cloudwatch_observability branch from 7a34d4f to ea8f5c6 Compare December 16, 2023 00:27
@bryantbiggs bryantbiggs changed the title feat: Add support for Amazon CloudWatch Observability IRSA role feat: Add support for Amazon CloudWatch Observability IRSA role Dec 16, 2023
@bryantbiggs bryantbiggs marked this pull request as ready for review December 16, 2023 00:58
Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


statement {
sid = "CollectEBSVolumeIDs"
actions = ["ec2:DescribeVolumes"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this is already covered in the CloudWatchAgentServerPolicy managed policy - we can actually just use the two managed policies as is without a custom policy

@bryantbiggs bryantbiggs merged commit 25e2bf9 into terraform-aws-modules:master Dec 16, 2023
35 checks passed
antonbabenko pushed a commit that referenced this pull request Dec 16, 2023
## [5.33.0](v5.32.1...v5.33.0) (2023-12-16)

### Features

* Add support for Amazon CloudWatch Observability IRSA role ([#446](#446)) ([25e2bf9](25e2bf9))
@antonbabenko
Copy link
Member

This PR is included in version 5.33.0 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants