-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for Amazon CloudWatch Observability IRSA role #446
feat: Add support for Amazon CloudWatch Observability IRSA role #446
Conversation
Currently running into an issue in testing these changes. Attempting to deploy
This issue is also present in the master branch. @bryantbiggs thoughts? |
7a34d4f
to
ea8f5c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks! The error was the example here https://github.com/terraform-aws-modules/terraform-aws-iam/pull/446/files#diff-2ba4c6896f0e2eaef7e8dd3128c6c92985731db0a77e40313e8213e78a19db3aR28
|
||
statement { | ||
sid = "CollectEBSVolumeIDs" | ||
actions = ["ec2:DescribeVolumes"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
since this is already covered in the CloudWatchAgentServerPolicy
managed policy - we can actually just use the two managed policies as is without a custom policy
## [5.33.0](v5.32.1...v5.33.0) (2023-12-16) ### Features * Add support for Amazon CloudWatch Observability IRSA role ([#446](#446)) ([25e2bf9](25e2bf9))
This PR is included in version 5.33.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
feat: Add support for Amazon CloudWatch Observability IRSA role
Motivation and Context
Adding support for creating IRSA role for Amazon CloudWatch Observability add-on
Breaking Changes
N/A
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request