feat: Add support for multiple route tables to public and intra subnets #1051
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinSnyderCodes
changed the title
|
@bryantbiggs Any interest in introducing this feature to the module? I'm happy to update the examples and finalize this PR if this is something you'd be open to merging. |
|
tf-controller plan output: No changes. Your infrastructure matches the configuration.
Terraform has compared your real infrastructure against your configuration
and found no differences, so no changes are needed.
To apply this plan, please merge this pull request. |
|
Any movements on this? Would love to have it. |
bryantbiggs
approved these changes
Apr 25, 2024
antonbabenko
pushed a commit
that referenced
this pull request
Apr 25, 2024
## [5.8.0](v5.7.2...v5.8.0) (2024-04-25) ### Features * Add support for multiple route tables to public and intra subnets ([#1051](#1051)) ([da05f24](da05f24))
|
This PR is included in version 5.8.0 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Support for multiple route tables when creating public and intra subnets.
Motivation and Context
Guarantee that the used route table for public and intra subnets on creation is different when a boolean variable is set to true.
Breaking Changes
No breaking changes, as the variables are optional and defaulted to
false.How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull requestChanges were tested in a staging environment where existing public and intra subnets and route tables existed. Multiple route tables were enabled for both public and intra subnets. The existing route tables and associations were successfully updated and network traffic continued to flow as normal.