feat: create subfolders for business units in 4-projects step #1039
Conversation
…-foundation into feature/create-folders-for-business-units
romanini-ciandt
requested review from
rjerrems,
gtsorbo and
a team
as code owners
| @@ -82,8 +82,7 @@ locals { | |||
| "roles/dns.admin", | |||
| ], | |||
| "proj" = [ | |||
| "roles/resourcemanager.folderViewer", | |||
| "roles/resourcemanager.folderIamAdmin", | |||
| "roles/resourcemanager.folderAdmin", | |||
There was a problem hiding this comment.
This permission is needed because now 4-projects step creates the proper subfolders by example BUs (before all the folders were created at 2-environments).
folderAdmin because we need permissions to create and destroy.
There was a problem hiding this comment.
Looks like a hyphen got dropped in the change between business_code and project_suffix "${var.project_prefix}-${local.env_code}-${var.business_code}${var.project_suffix}"
There was a problem hiding this comment.
@eeaton in order to achieve the requested example we have at the backlog (from prj-bu1-{env}-foo to prj-{env}-bu1foo) I intentionally dropped the hyphen here.
Let me know if sounds good for you or if I misunderstood the request.
Thanks!
There was a problem hiding this comment.
Thanks for the clarification, I thought the variable project_suffix expanded to the 4 digit random id, but if it expands to "prj-{env}-bu1foo-1234" that is correct how you wrote it.
…ers-for-business-units
|
/gcbrun |
The goal of this PR is to introduce GCP subfolders per business unit (1 & 2) for all
fldr-{env}folders in 4-projects step.In addition to the folder structure, a minor change at the BU's project name was introduced. See the example below:
Current:
Suggested: (including folder structure change + fixes to naming convention)
Evidence:
