Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cloudbuild triggers match unexpected branches #208

Closed
rjerrems opened this issue Aug 6, 2020 · 1 comment
Closed

Cloudbuild triggers match unexpected branches #208

rjerrems opened this issue Aug 6, 2020 · 1 comment

Comments

@rjerrems
Copy link
Collaborator

rjerrems commented Aug 6, 2020

Currently Cloud Build will trigger builds on branches that are not an exact match:

Screenshot from 2020-08-06 11-04-00

Thankfully, the wrapper scripts protects against anything being applied:

Finished Step #0 - "setup"
Starting Step #1 - "tf init"
Step #1 - "tf init": Already have image (with digest): gcr.io/cft-cloudbuild-9c00/terraform
Step #1 - "tf init": production doesn't match production2; skipping
Step #1 - "tf init": non-production doesn't match production2; skipping
Step #1 - "tf init": development doesn't match production2; skipping
Step #1 - "tf init": refs doesn't match production2; skipping
Step #1 - "tf init": objects doesn't match production2; skipping
Step #1 - "tf init": logs doesn't match production2; skipping
Step #1 - "tf init": info doesn't match production2; skipping
Step #1 - "tf init": hooks doesn't match production2; skipping
Step #1 - "tf init": branches doesn't match production2; skipping
Step #1 - "tf init": production doesn't match production2; skipping
Step #1 - "tf init": non-production doesn't match production2; skipping
Step #1 - "tf init": development doesn't match production2; skipping

Although we should update the bootstrap module, to ensure that no build is triggered at all. Related to this issue:

terraform-google-modules/terraform-google-bootstrap#52
@rjerrems rjerrems changed the title Cloudbuild triggers matches unexpected branches Cloudbuild triggers match unexpected branches Aug 6, 2020
@rjerrems rjerrems mentioned this issue Aug 6, 2020
Merged
@rjerrems
Copy link
Collaborator Author

rjerrems commented Aug 6, 2020

Fixed by terraform-google-modules/terraform-google-bootstrap#53

@rjerrems rjerrems closed this as completed Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rjerrems