Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add network fixture prepare to lint test #323

Merged
merged 2 commits into from
Feb 5, 2021

Conversation

bharathkkb
Copy link
Member

No description provided.

Copy link
Collaborator

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rjerrems
Copy link
Collaborator

rjerrems commented Feb 4, 2021

@bharathkkb I think we will need to do something about this as only one can exist at a time and will cause tests to fail

Error: Error creating Policy: googleapi: Error 409: The resource 'entity.policy' named 'dp-p-shared-base-default-policy' already exists, alreadyExists

I have re-run the one failed build 🤞

@bharathkkb
Copy link
Member Author

@rjerrems That is odd, from the logs I don't see any other dp-p-shared-base-default-policy being created either. It was created in default mode test but IIUC this resource is namespaced to the project projects/tst-p-shared-base-xxxx/policies/dp-p-shared-base-default-policy

@rjerrems rjerrems merged commit e090e79 into develop Feb 5, 2021
@eeaton eeaton deleted the fix-lint-hub-and-spoke branch June 3, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants