Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set the location for cloud build related buckets in step4 based in the default region #667

Merged
merged 4 commits into from
Apr 4, 2022
Merged

set the location for cloud build related buckets in step4 based in the default region #667

merged 4 commits into from
Apr 4, 2022

Conversation

daniel-cit
Copy link
Contributor

Fixes #666

@daniel-cit daniel-cit marked this pull request as ready for review March 29, 2022 02:01
@daniel-cit daniel-cit requested review from a team, rjerrems and bharathkkb as code owners March 29, 2022 02:01
bharathkkb
bharathkkb approved these changes Mar 29, 2022
View reviewed changes
Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor nit, LGTM otherwise

4-projects/modules/infra_pipelines/main.tf Outdated Show resolved Hide resolved
@bharathkkb bharathkkb merged commit b2b3aca into terraform-google-modules:master Apr 4, 2022
@release-please release-please bot mentioned this pull request Apr 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharathkkb bharathkkb bharathkkb approved these changes

@rjerrems rjerrems Awaiting requested review from rjerrems rjerrems is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Buckets for the infra pipeline create in step 4 should used the default region provided by the user
2 participants
@daniel-cit @bharathkkb