Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enforce expected output keys of each stage in the test #800

Closed
bharathkkb opened this issue Sep 9, 2022 · 0 comments
Closed

Enforce expected output keys of each stage in the test #800

bharathkkb opened this issue Sep 9, 2022 · 0 comments
Labels
enhancement New feature or request P2 high priority issues testing triaged Scoped and ready for work

Comments

@bharathkkb
Copy link
Member

TL;DR

With #782 we now use remote state. Stages maybe dependent on the previous states output and if any output key is changed unknowingly we won't will waste build time until a remote data call tries to pull the old key and fails. T

To prevent these kind of failures and enforce stronger guarantees, I propose we add validation at the end of each stage to enforce all expected output keys are present. We could likely use https://github.com/GoogleCloudPlatform/cloud-foundation-toolkit/tree/master/infra/blueprint-test/pkg/golden to create a golden json file with all expected keys and assert at the end of each stage.

Terraform Resources

No response

Detailed design

No response

Additional information

No response

@bharathkkb bharathkkb added the enhancement New feature or request label Sep 9, 2022
@bharathkkb bharathkkb added testing triaged Scoped and ready for work P2 high priority issues labels Sep 9, 2022
@eeaton eeaton closed this as completed May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request P2 high priority issues testing triaged Scoped and ready for work
Projects
None yet
Development

No branches or pull requests

2 participants