Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 service accounts created in the seed project #109

Closed
crazyrov opened this issue Jun 4, 2021 · 2 comments · Fixed by #124
Closed

2 service accounts created in the seed project #109

crazyrov opened this issue Jun 4, 2021 · 2 comments · Fixed by #124
Labels
good first issue Good for newcomers triaged Scoped and ready for work

Comments

@crazyrov
Copy link

crazyrov commented Jun 4, 2021

The terraform-google-bootstrap created 2 service account. Once that we used to deploy the remaining infrastructure which is desired.
There is another service account getting created because the module used the project-factory without the create_project_sa being set to any the default value for this parameter is true in the core-project-factory module.
It would be great if we have an option to enable or disable the creation this default service account or I would say just disable it as we are getting the org-terraform being created for the actual purposes of deploying the rest of the IaC.

@rjerrems
Copy link
Contributor

rjerrems commented Jun 7, 2021

Yeah this makes sense @crazyrov - we have no real use for the project_sa at the moment so we could also just toggle create_project_sa to false.

@bharathkkb - any reason you can see why we should not do this?

@bharathkkb
Copy link
Member

@rjerrems agreed, we can default to false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers triaged Scoped and ready for work
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants