feat: create Cloudbuild Source submodule #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bharathkkb
reviewed
Jul 13, 2022
modules/tf_cloudbuild_core/main.tf
Outdated
| source = "terraform-google-modules/cloud-storage/google//modules/simple_bucket" | ||
| version = "~> 3.2" | ||
|
|
||
| name = "${module.cloudbuild_project.project_id}_cloudbuild" |
There was a problem hiding this comment.
What do we use this bucket for?
There was a problem hiding this comment.
this is the default cloud build bucket, the one used for source staging.
if not created here it will be created in the fist time a build is run and it will be always created in the "US" location, independent of where the bootstrap infrastructure is been created.
same as terraform-google-modules/terraform-example-foundation#666
There was a problem hiding this comment.
Got it, lets add a comment here with any upstream docs if any.
There was a problem hiding this comment.
added an explanation
@bharathkkb could you PTAL?
daniel-cit
changed the title
bharathkkb
approved these changes
Jul 14, 2022
|
@daniel-cit |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submodule that creates: