Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add skip_gcloud_download for all PF instances #39

Merged
merged 1 commit into from
Jun 30, 2020
Merged

Add skip_gcloud_download for all PF instances #39

merged 1 commit into from
Jun 30, 2020

Conversation

bharathkkb
Copy link
Member

@bharathkkb bharathkkb commented Jun 30, 2020 •
edited
Loading

As discussed offline for terraform-google-modules/terraform-example-foundation#61

  • Adds skip_gcloud_download for all PF instances defaulting to true

  • Also bumped PF to latest version

@bharathkkb bharathkkb requested review from rjerrems and morgante June 30, 2020 01:48
rjerrems
rjerrems approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@rjerrems rjerrems left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bharathkkb
Copy link
Member Author

bharathkkb commented Jun 30, 2020 •
edited
Loading

@morgante could you cut a release with this as it would help with my local testing runs for foundation.

@morgante morgante merged commit 0e06b29 into master Jun 30, 2020
@release-please release-please bot mentioned this pull request Aug 11, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rjerrems rjerrems rjerrems approved these changes

@morgante morgante Awaiting requested review from morgante

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bharathkkb @rjerrems @morgante