Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade module version #93

Merged

Conversation

ericyz
Copy link
Contributor

@ericyz ericyz commented Feb 18, 2021

The project-factory min support TF version is v0.13.0 now, so update the Terraform version used in Cloud Build module

@comment-bot-dev
Copy link

comment-bot-dev commented Feb 18, 2021

Thanks for the PR! 🚀
✅ Lint checks have passed.

@rjerrems
Copy link
Contributor

@ericyz thanks for the PR :) - it looks like the docker build is failing with these updated parameters. Can you verify that it is working as expected through a local run?

Also for consistency, can you please also update these files? (they help ensure the cloudbuild YAML and Dockerfile can still be used in isolation from the rest of the code)

https://github.com/terraform-google-modules/terraform-google-bootstrap/blob/master/modules/cloudbuild/cloudbuild_builder/Dockerfile#L17

https://github.com/terraform-google-modules/terraform-google-bootstrap/blob/master/modules/cloudbuild/cloudbuild_builder/cloudbuild.yaml#L30

@rjerrems
Copy link
Contributor

/gcbrun

@ericyz ericyz requested a review from rjerrems February 22, 2021 08:17
@ericyz
Copy link
Contributor Author

ericyz commented Feb 22, 2021

Thanks @rjerrems ! I used the wrong terraform hash and it's been updated now.

@rjerrems
Copy link
Contributor

Looks like you need to regenerate docs again @ericyz

@rjerrems
Copy link
Contributor

The other error looks like too many concurrent runs happening elsewhere, so should be ok once linting is fixed.

@rjerrems rjerrems merged commit e04ab65 into terraform-google-modules:master Feb 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants