Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: added confidential-nodes flag for node-pools #2110

Conversation

t-indumathy
Copy link
Contributor

@t-indumathy t-indumathy commented Sep 23, 2024

Motivation
The current set of confidential node support is available only at the cluster level, but the confidential node support at the node level is required to have new node pools created with confidential nodes.

Summary of changes
Added enable_confidential_nodes variable at the node pool level.

P.S: This is addressing the issue #1386 and has same changes as that of the PR #1756. As the PR author has not responded for the review comments, I'm thus creating a fresh PR as this feature is needed at the earliest.

Fixes: #1386
Closes: #1756

@t-indumathy t-indumathy requested review from ericyz, gtsorbo and a team as code owners September 23, 2024 17:26
Copy link

google-cla bot commented Sep 23, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@t-indumathy t-indumathy changed the title Added confidential-node flag for node-pool config feat: added confidential-nodes flag for node-pools Sep 23, 2024
@apeabody
Copy link
Contributor

/gcbrun

Copy link
Contributor

@apeabody apeabody left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

autogen/main/cluster.tf.tmpl Outdated Show resolved Hide resolved
@t-indumathy
Copy link
Contributor Author

Thanks for the contribution @t-indumathy!

Can you please document the new variable here: https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/README.md?plain=1#L190

This is already present at https://github.com/terraform-google-modules/terraform-google-kubernetes-engine/blob/master/autogen/main/README.md?plain=1#L204 .

@apeabody
Copy link
Contributor

apeabody commented Oct 1, 2024

/gcbrun

@apeabody
Copy link
Contributor

apeabody commented Oct 1, 2024

/gcbrun

@t-indumathy
Copy link
Contributor Author

@apeabody Can you pls let me know the details on why the pipeline is unsuccessful.

@apeabody
Copy link
Contributor

apeabody commented Oct 2, 2024

@apeabody Can you pls let me know the details on why the pipeline is unsuccessful.

Hi @t-indumathy - I'm going to re-run the tests. A node pool failed to create, but I don't believe it's related to this change.

@apeabody
Copy link
Contributor

apeabody commented Oct 2, 2024

/gcbrun

@apeabody apeabody enabled auto-merge (squash) October 2, 2024 16:19
@apeabody apeabody merged commit b2a597b into terraform-google-modules:master Oct 2, 2024
4 checks passed
@t-indumathy
Copy link
Contributor Author

@apeabody can you pls backport this feature to v30.0.

@apeabody
Copy link
Contributor

apeabody commented Oct 7, 2024

@apeabody can you pls backport this feature to v30.0.

Hi @t-indumathy - Unfortunately we don't do backport releases and instead recommend updating to the latest module version, however if required you could fork the v30.0 release for your changes and use a custom module source. Best Wishes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support confidential nodepools
2 participants