feat: add memcache_version parameter #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
bruno561
changed the title
bruno561
force-pushed
the
feature/memcache_version
branch
from
4cd4b47
to
9a913d1
Compare
imrannayer
reviewed
Dec 8, 2023
|
@imrannayer asap, can you review again please? |
|
@bruno561 can u plz fix lint issue? |
Can you give more context of the error so I can adjust? I didn't find much information in the run output. |
|
@imrannayer I added this new commit and ran make |
|
/gcbrun |
|
/gcbrun |
imrannayer
approved these changes
Dec 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose that we add the memcached version parameter.
Doc: https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/memcache_instance#memcache_version
Related issue: #184