-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added replica_count and replicas_mode functionality #88
Conversation
there's a check failing but i am not able to understand why... can anybody help? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @rs1986x
The test is failing with
apply.go:34:
Error Trace: apply.go:34
terraform.go:312
terraform.go:322
terraform.go:346
stages.go:31
terraform.go:346
Error: Received unexpected error:
FatalError{Underlying: error while running command: exit status 1; ╷
│ Error: Error creating Instance: googleapi: Error 400: Setting replica count requires read-replicas-mode to be "READ_REPLICAS_ENABLED"
│ com.google.apps.framework.request.StatusException: <eye3 title='INVALID_ARGUMENT'/> generic::INVALID_ARGUMENT: Setting replica count requires read-replicas-mode to be "READ_REPLICAS_ENABLED"
│ Details:
│ [
│ {
│ "@type": "type.googleapis.com/google.rpc.BadRequest",
│ "fieldViolations": [
│ {
│ "description": "Invalid value: 1",
│ "field": "instance.replica_count"
│ }
│ ]
│ }
│ ]
│
│ with module.memstore.google_redis_instance.default,
│ on ../../main.tf line 17, in resource "google_redis_instance" "default":
│ 17: resource "google_redis_instance" "default" {
│
╵}
Test: TestRedis
```
@rs1986x |
Any chance of getting this merged? I would like to utilize this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for the delay @rs1986x
I added the options to choose the read replicas types and number according to gcp documentation and terrraform
https://cloud.google.com/memorystore/docs/redis/reference/rest/v1/projects.locations.instances#readreplicasmode
https://registry.terraform.io/providers/hashicorp/google/latest/docs/resources/redis_instance