Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added replica_count and replicas_mode functionality #88

Merged
merged 4 commits into from
Jun 28, 2022

Conversation

rs1986x
Copy link
Contributor

@rs1986x rs1986x commented Jun 8, 2022

@rs1986x
Copy link
Contributor Author

rs1986x commented Jun 8, 2022

there's a check failing but i am not able to understand why... can anybody help?

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rs1986x
The test is failing with

    apply.go:34: 
        	Error Trace:	apply.go:34
        	            				terraform.go:312
        	            				terraform.go:322
        	            				terraform.go:346
        	            				stages.go:31
        	            				terraform.go:346
        	Error:      	Received unexpected error:
        	            	FatalError{Underlying: error while running command: exit status 1; ╷
        	            	│ Error: Error creating Instance: googleapi: Error 400: Setting replica count requires read-replicas-mode to be "READ_REPLICAS_ENABLED"
        	            	│ com.google.apps.framework.request.StatusException: <eye3 title='INVALID_ARGUMENT'/> generic::INVALID_ARGUMENT: Setting replica count requires read-replicas-mode to be "READ_REPLICAS_ENABLED"
        	            	│ Details:
        	            	│ [
        	            	│   {
        	            	│     "@type": "type.googleapis.com/google.rpc.BadRequest",
        	            	│     "fieldViolations": [
        	            	│       {
        	            	│         "description": "Invalid value: 1",
        	            	│         "field": "instance.replica_count"
        	            	│       }
        	            	│     ]
        	            	│   }
        	            	│ ]
        	            	│ 
        	            	│   with module.memstore.google_redis_instance.default,
        	            	│   on ../../main.tf line 17, in resource "google_redis_instance" "default":
        	            	│   17: resource "google_redis_instance" "default" {
        	            	│ 
        	            	╵}
        	Test:       	TestRedis
        	```

variables.tf Outdated Show resolved Hide resolved
@comment-bot-dev
Copy link

@rs1986x
Thanks for the PR! 🚀
✅ Lint checks have passed.

@thoreinstein
Copy link

Any chance of getting this merged? I would like to utilize this.

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the delay @rs1986x

@bharathkkb bharathkkb merged commit 3fcdba5 into terraform-google-modules:master Jun 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants