fix: Add shared_vpc features to root module back

[askoriy]

This PR fixes #445

[askoriy]

@morgante could you point to build error details to finally fix it and merge this PR?

[askoriy]

@morgante or @bharathkkb could you point me to error details?

[bharathkkb]

@askoriy
PFA

       Error: Invalid for_each argument
       
         on ../../../modules/shared_vpc_access/main.tf line 64, in resource "google_project_iam_member" "service_shared_vpc_user":
         64:   for_each = (length(var.shared_vpc_subnets) == 0) && (var.host_project_id != "") ? local.active_apis : []
       
       The "for_each" value depends on resource attributes that cannot be determined
       until apply, so Terraform cannot predict how many instances will be created.
       To work around this, use the -target argument to first apply only the
       resources that the for_each depends on.

[bharathkkb]

@morgante as discussed here #445 (comment) are we planning on adding this back to the root module or updating docs to reflect usage of shared_vpc submodule?

[morgante]

@morgante as discussed here #445 (comment) are we planning on adding this back to the root module or updating docs to reflect usage of shared_vpc submodule?

So long as we can get it to work properly, we should add it back in this release. If we want to remove it totally, that should be clearly communicated in the next major release.

[morgante]

/gcbbuild

[des-esseintes]

hey @askoriy do you still think this stuff has to be merged or maybe you found some workaround to make life easier with the existing functionality?