Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add budget notification channel #456

Conversation

davidholsgrove
Copy link
Contributor

@davidholsgrove davidholsgrove commented Sep 14, 2020

Allow configuring billing budget with monitoring notification channels.

Fixes #455

@davidholsgrove
Copy link
Contributor Author

Hi @adrienthebo / @morgante - any chance of a review on this PR?
The budget alerts through Monitoring Notification channel email appear to be more useful out-of-the-box than the pub/sub method, due to the budget publishing messages multiple times a day, not just at budget threshold.

@morgante
Copy link
Contributor

Thanks for the contribution! @davidholsgrove Do you think we should accept the email and create the channel inline within the module?

@davidholsgrove
Copy link
Contributor Author

Thanks for the contribution! @davidholsgrove Do you think we should accept the email and create the channel inline within the module?

Good question - I followed the approach in the module currently, where we don't create the pub/sub resources, and just take the topic name as a var.

I think creating the notification channel in-module might be more difficult, as in practice if people follow https://cloud.google.com/monitoring/workspaces#monitored-projects the monitoring workspace project will be different from the budget project

@morgante
Copy link
Contributor

@davidholsgrove Good point, I think this is fine as is. We could adjust this later if need be.

@morgante morgante merged commit 9bc317e into terraform-google-modules:master Sep 23, 2020
@davidholsgrove davidholsgrove deleted the feature/budget-notification-channel branch September 23, 2020 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add monitoring_notification_channels to modules/budget
2 participants