Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add Dataflow to Shared VPC API service accounts #458

Merged

Conversation

zefdelgadillo
Copy link
Contributor

Add Dataflow API service account to Shared VPC host project if API is enabled on new projects. see https://cloud.google.com/dataflow/docs/concepts/security-and-permissions#cloud_dataflow_service_account

Copy link
Member

@bharathkkb bharathkkb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Thanks for the PR!

@bharathkkb bharathkkb merged commit 0c5adf3 into terraform-google-modules:master Sep 18, 2020
@zefdelgadillo zefdelgadillo deleted the dataflow-shared-vpc branch September 18, 2020 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants