Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename shared_vpc #463

Closed
morgante opened this issue Oct 1, 2020 · 3 comments · Fixed by #517
Closed

Rename shared_vpc #463

morgante opened this issue Oct 1, 2020 · 3 comments · Fixed by #517
Assignees
@ChandranshuRao14
Labels
enhancement New feature or request next-major

Comments

@morgante
Copy link
Contributor

morgante commented Oct 1, 2020

We could have a clearer name for the shared vpc variable as discussed here.
@morgante morgante added enhancement New feature or request next-major labels Oct 1, 2020
@morgante morgante mentioned this issue Oct 1, 2020
Closed
@thiagonache
Copy link
Contributor

Also, we should rename shared_vpc_enabled to enable_shared_vpc_service_project everywhere

@thiagonache
Copy link
Contributor

Let me know if I can help with it somehow.

@bharathkkb bharathkkb mentioned this issue Dec 14, 2020
Merged
@ChandranshuRao14 ChandranshuRao14 self-assigned this Dec 14, 2020
@morgante
Copy link
Contributor Author

For context, the only need here is to rename the submodule to something like service_project or svpc_service_project and to rename enable_shared_vpc_service_project.

@ChandranshuRao14 ChandranshuRao14 mentioned this issue Dec 15, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ChandranshuRao14 ChandranshuRao14

Labels
enhancement New feature or request next-major
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: rename shared_vpc submodule ChandranshuRao14/terraform-google-project-factory
3 participants
@morgante @thiagonache @ChandranshuRao14